Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtentEntityCopy does nothing when used with a non-IChunkExtent #2446

Open
2 tasks done
opl- opened this issue Oct 6, 2023 · 0 comments
Open
2 tasks done

ExtentEntityCopy does nothing when used with a non-IChunkExtent #2446

opl- opened this issue Oct 6, 2023 · 0 comments
Labels
Requires Testing This is a new issue which needs to be approved before labeled with "bug"

Comments

@opl-
Copy link
Contributor

opl- commented Oct 6, 2023

Server Implementation

Paper

Server Version

1.20.2

Describe the bug

ExtentEntityCopy hits the default implementation of Extent.createEntity

https://github.com/opl-/FastAsyncWorldEdit/blob/f812fc14abdd23d3d131395f02d5526dd8095389/worldedit-core/src/main/java/com/sk89q/worldedit/extent/Extent.java#L147

when trying to use it with a BukkitAdapter.adapt(world). A quick investigation leads to the following line:

https://github.com/opl-/FastAsyncWorldEdit/blob/79a2c14caacee4fdd64e51e43fde382118750781/worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitWorld.java#L170

IChunkExtent, being a FAWE construct, breaks compatibility.

To Reproduce

Use reproduction steps from #2445.

Expected behaviour

Some sorta automatic fallback? Not sure.

Screenshots / Videos

No response

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/f05eca59ab7a4e188ced658f1f9ffa4c

Fawe Version

FastAsyncWorldEdit version 2.8.0

Checklist

Anything else?

No response

@opl- opl- added the Requires Testing This is a new issue which needs to be approved before labeled with "bug" label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Requires Testing This is a new issue which needs to be approved before labeled with "bug"
Projects
None yet
Development

No branches or pull requests

1 participant