-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better error handling for infisical secret set
#1839
Comments
I also ran into this immediately, perhaps it's possible to lean on Cobra instead of having your own splitting logic. You can use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you omit the
=
sign fromsecrets
set
command, the CLI panics:The panic is caused by the following code:
https://github.com/Infisical/infisical/blob/main/cli/packages/cmd/secrets.go#L229-L232
This could be better handled by the CLI. For example, if we check the bound of the
splitKeyValueFromArg
slice, we can provide a more user-friendly error message:I'm happy to put in a PR if you all are interested in this change.
Thanks for building this tool!
The text was updated successfully, but these errors were encountered: