Skip to content
This repository has been archived by the owner on Sep 27, 2022. It is now read-only.

Please reconsider generating fixed resolution images #1

Open
Diniboy1123 opened this issue Jul 9, 2019 · 1 comment
Open

Please reconsider generating fixed resolution images #1

Diniboy1123 opened this issue Jul 9, 2019 · 1 comment

Comments

@Diniboy1123
Copy link
Contributor

Now that there was a breaking change in the backgrounds, it's time to reconsider uncommenting or editing the commented part here:

https://github.com/Kenvyra/okapi/blob/831c612a88528415182526ca39d800be025606b5/routes/api/genprofile.js#L57

This change would always resize the overlay images before drawing anything onto them therefore it'd be impossible to add a large image which basically breaks the looking and it'd be fixed size for everyone.

The only reason why I couldn't apply it before was because it will break the positioning of the current custom backgrounds.

PS: Maybe we can add an optional setting to have it resized or not by the bot as a cmd argument if my last point would be an issue.

@Diniboy1123 Diniboy1123 changed the title Please reconsider generating fixed width images Please reconsider generating fixed resolution images Jul 9, 2019
@Gelbpunkt
Copy link
Contributor

I'm also not sure, as some people have bigger backgrounds to use some more space. Not really sure if i wanna change this or not

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants