Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: move index.d.ts alongside index.js main entry #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: move index.d.ts alongside index.js main entry #11

wants to merge 1 commit into from

Conversation

drwpow
Copy link

@drwpow drwpow commented Apr 3, 2023

Fixes #10.

Before

CleanShot 2023-04-03 at 13 38 47

After

CleanShot 2023-04-03 at 13 39 07

drwpow
drwpow commented Apr 3, 2023
View reviewed changes
package.json
@@ -5,7 +5,6 @@
"type": "module",
"main": "src/index.js",
"module": "src/index.js",
"types": "types",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Only question is for types/test.ts. How should users expect to consume that file?

@drwpow drwpow mentioned this pull request Apr 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript 5.x isn’t picking up types correctly
1 participant
@drwpow