Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Convert all JPA queries to use @NamedQuery #3903

Closed
michbarsinai opened this issue Jun 14, 2017 · 3 comments
Closed

Cleanup: Convert all JPA queries to use @NamedQuery #3903

michbarsinai opened this issue Jun 14, 2017 · 3 comments

Comments

@michbarsinai
Copy link
Member

No description provided.

@pdurbin
Copy link
Member

pdurbin commented Jun 28, 2017

@michbarsinai thanks for opening this ticket. Please help me with #3950 first and then we'll document what you're talking about either under a newer version of http://guides.dataverse.org/en/4.7/developers/coding-style.html or under a new page called "Code Quality" which would include a section on type safety.

The idea is that we don't just change the code. We start by setting expectations with other developers in the dev guide. Then we have something to point at when we say they should use type safe database queries. Please ping me at http://chat.dataverse.org if I'm not being clear enough. Thanks!

@pdurbin
Copy link
Member

pdurbin commented Jun 28, 2017

@michbarsinai oh, here are two recent examples of "set expectation" issues I've worked on:

@pdurbin
Copy link
Member

pdurbin commented Jun 29, 2017

Closing to consolidate into #3950.

@pdurbin pdurbin closed this as completed Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants