Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Object.finalize() must call super.finalize() #2675

Closed
bencomp opened this issue Oct 22, 2015 · 1 comment
Closed

Implementation of Object.finalize() must call super.finalize() #2675

bencomp opened this issue Oct 22, 2015 · 1 comment

Comments

@bencomp
Copy link
Contributor

bencomp commented Oct 22, 2015

SonarQube found a few issues that must be solved immediately. One is the violation of the rule "super.finalize() should be called at the end of Object.finalize() implementations" in ServiceRegistry.

Rationale:

Overriding the Object.finalize() method must be done with caution to dispose some system resources.
Calling the super.finalize() at the end of this method implementation is highly recommended in case parent implementations must also dispose some system resources.

I found it strange that this class and related classes are even in the codebase, seeing that they have been copied from an old JDK and are still in the JDK in a form with generics as javax.imageio.spi.ServiceRegistry. It creates some copyright issues too, as I mentioned in #2576.

@mercecrosas mercecrosas modified the milestone: In Review Nov 30, 2015
@mheppler mheppler added the Component: Code Infrastructure formerly "Feature: Code Infrastructure" label Jan 28, 2016
@scolapasta scolapasta modified the milestone: Not Assigned to a Release Jan 28, 2016
@pdurbin
Copy link
Member

pdurbin commented Jun 29, 2017

Closing to consolidate into #3950.

@pdurbin pdurbin closed this as completed Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants