Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HandlenetServiceBean must not catch Throwables #2674

Closed
bencomp opened this issue Oct 22, 2015 · 2 comments
Closed

HandlenetServiceBean must not catch Throwables #2674

bencomp opened this issue Oct 22, 2015 · 2 comments

Comments

@bencomp
Copy link
Contributor

bencomp commented Oct 22, 2015

SonarQube found some issues that must be addressed immediately, among which are four violations of the rule "Throwable and Error should not be caught", all found in HandlenetServiceBean.

Rationale:

Throwable is the superclass of all errors and exceptions in Java.
Error is the superclass of all errors, which are not meant to be caught by applications.
Catching either Throwable or Error will also catch OutOfMemoryError and InternalError, from which an application should not attempt to recover.
Only Exception and its subclasses should be caught.

@mercecrosas mercecrosas modified the milestone: In Review Nov 30, 2015
@mheppler mheppler added the Component: Code Infrastructure formerly "Feature: Code Infrastructure" label Jan 28, 2016
@scolapasta scolapasta modified the milestone: Not Assigned to a Release Jan 28, 2016
@pdurbin
Copy link
Member

pdurbin commented Jun 29, 2017

Closing to consolidate into #3950.

@pdurbin pdurbin closed this as completed Jun 29, 2017
@bencomp
Copy link
Contributor Author

bencomp commented Aug 30, 2023

Triggered by #9846, I notice that Sonarcloud does not mark this still existing issue as problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants