Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Metadata: support boolean values #7961

Open
foobarbecue opened this issue Jun 21, 2021 · 11 comments · May be fixed by #10480
Open

Custom Metadata: support boolean values #7961

foobarbecue opened this issue Jun 21, 2021 · 11 comments · May be fixed by #10480

Comments

@foobarbecue
Copy link
Contributor

foobarbecue commented Jun 21, 2021

It would be very useful to add a fieldType to support inclusion of true / false information. Some discussion with workarounds on the google group here.

@poikilotherm
Copy link
Contributor

Somewhat related to #5989

@pdurbin pdurbin changed the title Custom Metadata: support booean values Custom Metadata: support boolean values Feb 3, 2022
@Asbjoedt
Copy link

Hi @pdurbin
Do you have any news on implementing this feature?
It is something we want to use in a custom metadata block for our forthcoming Dataverse, so users can tick the box/field, if they regard the dataset relevant for submission to National Archives repository.

@pdurbin
Copy link
Member

pdurbin commented Nov 28, 2023

@Asbjoedt no news. Let me mention @scolapasta and @cmbz to let them know you (and others) are interested.

Is this something you (or others) might want to create pull request for? That often helps move things along. 😄

I agree it would be a nice feature.

@pdurbin
Copy link
Member

pdurbin commented Nov 29, 2023

@Asbjoedt also, in the past I've encouraged installations to maintain a project/board of issues they care about. A great current example is https://github.com/orgs/IQSS/projects/15 maintained mostly by @DS-INRA.

If you'd like a board like this, please open an issue at https://github.com/IQSS/dataverse-installations using the "request a project board" template.

@cmbz
Copy link

cmbz commented Nov 30, 2023

@jggautier Any connection here with the NIH GREI metadata recommendations?

@jggautier
Copy link
Contributor

jggautier commented Nov 30, 2023

Hmm, yeah having the option to use a checkbox might help depositors provide information that those recommendations ask for.

@Asbjoedt
Copy link

@pdurbin I can try to look at the source code. I know some Java and strictly speaking this is about implementing the Java boolean data type as a Dataverse data type for metadata blocks, if you agree on this approach?

I've found the file "DatasetFieldType", may you provide me with a list of names of other files that are necessary to change to implement the boolean?

I can't promise, I can create a PR for this, but I may take a look.
I have forked the repo and created a branch, is this sufficient for you to receive a PR?

@pdurbin
Copy link
Member

pdurbin commented Nov 30, 2023

@Asbjoedt great! For details on what files to edit (I'd need to look) maybe you can start a thread in #dev at https://chat.dataverse.org and we can figure it out together.

@cmbz
Copy link

cmbz commented Dec 2, 2023

@Asbjoedt Please comment here if you decide to make a PR. After discussion with @jggautier this issue appears to be aligned with our NIH GREI objectives.

@pdurbin
Copy link
Member

pdurbin commented Dec 7, 2023

Here's the conversation so far: https://dataverse.zulipchat.com/#narrow/stream/379673-dev/topic/The.20boolean/near/405225599

To summarize, I agree with @poikilotherm that his commit at https://jugit.fz-juelich.de/fdm/dev/dataverse/-/commit/d4aece03aebcf9c2237aa7842c17c0d96af6a79a is a good one to study.

@sbondka sbondka moved this from 🔍 Interest to 🕒 Planned Development in Recherche Data Gouv (formerly Data INRAE) Jan 10, 2024
@sbondka sbondka moved this from 🕒 Planned Development to 🚧 Dev by Recherche Data Gouv in Recherche Data Gouv (formerly Data INRAE) Jan 10, 2024
@jeromeroucou jeromeroucou linked a pull request Apr 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Metadata Type: Suggestion an idea User Role: Depositor Creates datasets, uploads data, etc.
Projects
Recherche Data Gouv (formerly Data IN...
  
🚧 Dev by Recherche Data Gouv
Development

Successfully merging a pull request may close this issue.

6 participants