Use try-with-resources to guarantee closing of JsonReader in .../api/DataSets.java

[rtreacy]

What steps does it take to reproduce the issue?
This issue is reported by running static analysis with SonarQube or SonarCloud

• When does this issue occur?
  There are 7 occurrences of this code:
  JsonObject json = Json.createReader(rdr).readObject();

in DataSets.java in the following methods -

public Response updateDraftVersion(...)
private Response processDatasetFieldDataDelete(...)
private Response processDatasetUpdate(...)
public Response createFileEmbargo(...)
public Response removeFileEmbargo(...)
public Response returnToAuthor(...)
public Response completeMPUpload(...)

• What happens?
  This can prevent JsonReader objects from properly closing and being Garbage Collected and thus prevent referenced objects from being GCed as well.

[qqmyers]

As with earlier issues, replacing these with the appropriate JsonUtil method would be a good fix.

dataverse/src/main/java/edu/harvard/iq/dataverse/util/json/JsonUtil.java

Lines 62 to 77 in 0af5caf

	public static jakarta.json.JsonObject getJsonObject(String serializedJson) {
	try (StringReader rdr = new StringReader(serializedJson)) {
	try (JsonReader jsonReader = Json.createReader(rdr)) {
	return jsonReader.readObject();
	}
	}
	}
	public static jakarta.json.JsonArray getJsonArray(String serializedJson) {
	try (StringReader rdr = new StringReader(serializedJson)) {
	try (JsonReader jsonReader = Json.createReader(rdr)) {
	return jsonReader.readArray();
	}
	}
	}
	}

[bencomp]

Ah, this is the issue I didn't create for #9980. I think that PR fixes this.

[rtreacy]

Great, thanks for being proactive on this. We will be reviewing. #9980 soon