Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe #0064: a Canvas has multiple AnnotationPage #220

Closed
2SC1815J opened this issue Dec 26, 2020 · 1 comment · Fixed by #221
Closed

Recipe #0064: a Canvas has multiple AnnotationPage #220

2SC1815J opened this issue Dec 26, 2020 · 1 comment · Fixed by #221
Assignees

Comments

@2SC1815J
Copy link
Member

In the recipe 0064, one Canvas has two AnnotationPage objects.

The manifesto.js library had not handled this case well.
IIIF-Commons/manifesto#86

Is there any reason not to write the Canvas as follows (one Canvas -> one AnnotationPage -> two Annotation objects) to achieve the intent of this recipe?

{
  "id": "https://iiif.io/api/cookbook/recipe/0064-opera-one-canvas/canvas/1",
  "type": "Canvas",
  "width": 1920,
  "height": 1080,
  "duration": 7278.46,
  "items": [
    {
      "id": "https://iiif.io/api/cookbook/recipe/0064-opera-one-canvas/canvas/1/annotation_page/1",
      "type": "AnnotationPage",
      "items": [
        {
          "id": "https://iiif.io/api/cookbook/recipe/0064-opera-one-canvas/canvas/1/annotation_page/1/annotation/1",
          "type": "Annotation",
          "motivation": "painting",
          "target": "https://iiif.io/api/cookbook/recipe/0064-opera-one-canvas/canvas/1#t=0,3971.24",
          "body": {
            "id": "https://fixtures.iiif.io/video/indiana/donizetti-elixir/vae0637_accessH264_low.mp4",
            "type": "Video",
            "format": "video/mp4",
            "height": 1080,
            "width": 1920,
            "duration": 3971.24
          }
        },
        {
          "id": "https://iiif.io/api/cookbook/recipe/0064-opera-one-canvas/canvas/1/annotation_page/1/annotation/2",
          "type": "Annotation",
          "motivation": "painting",
          "target": "https://iiif.io/api/cookbook/recipe/0064-opera-one-canvas/canvas/1#t=3971.24",
          "body": {
            "id": "https://fixtures.iiif.io/video/indiana/donizetti-elixir/vae0637_accessH264_low_act_2.mp4",
            "type": "Video",
            "format": "video/mp4",
            "height": 1080,
            "width": 1920,
            "duration": 3307.22
          }
        }
      ]
    }
  ]
}
@glenrobson
Copy link
Member

We discussed this in the Cookbook authors meeting on the 6th of January. We discussed that both options are valid in the IIIF spec but agreed the suggestion of having 1 annotation page with 2 annotations was a more optimal notation of this use case.

We discussed multiple annotation pages would be useful when there is some choice the user needs to make on which ones to show which isn't the case with this example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants