Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define v3 service profiles in a context / registry #1641

Closed
christopher-johnson opened this issue Jul 21, 2018 · 4 comments
Closed

define v3 service profiles in a context / registry #1641

christopher-johnson opened this issue Jul 21, 2018 · 4 comments

Comments

@christopher-johnson
Copy link

service profiles are not defined in the v3 context. client deserializers (e.g. manifesto) need to be able to reference a registry of supported values/terms/URIs. It looks like this document specifies that intention:
http://iiif.io/api/annex/registry/services/ though it is not implemented as a context.

I opened an issue in manifesto for this: IIIF-Commons/manifesto#34 . For example, "level2" is not a known reference.

@edsilv
Copy link
Contributor

edsilv commented Jul 24, 2018

I think for now the best thing would be to add entries to https://github.com/IIIF-Commons/manifesto/blob/master/src/ServiceProfile.ts

I'd really like to change this and other enums to use TypeScript String Enums too: https://blog.mariusschulz.com/2017/10/27/typescript-2-4-string-enums

This would have pretty far-reaching side-effects in manifold and UV, but I think probably an afternoon's work updating all references.

Perhaps we could then spin these enums out into a separate reusable npm module?

@azaroth42
Copy link
Member

They are indeed not defined. When we had separate contexts, they were, and when we combined them, they got lost. Thanks for the catch!

@edsilv
Copy link
Contributor

edsilv commented Jul 24, 2018

woops, posted my reply on the wrong repo!

@azaroth42
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants