Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests around Manifesto's auth logic #57

Open
mejackreed opened this issue Nov 4, 2019 · 4 comments
Open

Add tests around Manifesto's auth logic #57

mejackreed opened this issue Nov 4, 2019 · 4 comments

Comments

@mejackreed
Copy link
Contributor

No description provided.

@mejackreed
Copy link
Contributor Author

@edsilv are there some specific targeted pieces that you think should be tested?

@edsilv
Copy link
Member

edsilv commented Nov 6, 2019

I think the ideal thing could be to have an actual nodejs implementation of an auth server, and to make requests against that locally when running the test suite to test the auth utils.

We could potentially use something like passport.js to create access tokens and simulate a successful user interaction login via twitter/whatever?

@mejackreed
Copy link
Contributor Author

It sounds great to have that entire functionality tested. Would it be ok to start from a simpler place though for the manifesto test suite that gets us closer to a release?

#58 Just adds some basic tests around Utils. I look at a more comprehensive approach also.

@edsilv
Copy link
Member

edsilv commented Nov 7, 2019

Sure, sounds good.

edsilv added a commit that referenced this issue Dec 19, 2019
Adds unit tests around Utils starting work on #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants