Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifesto Canvas returning native quality on a manifest with context 2.0 #47

Open
jeffreycwitt opened this issue Feb 7, 2019 · 0 comments

Comments

@jeffreycwitt
Copy link
Contributor

I thin Manifesto/Canvas is returning quality "native" in the following lines

manifesto/src/Canvas.ts

Lines 28 to 32 in 3217f1e

if (this.externalResource.data['@context']) {
if (this.externalResource.data['@context'].indexOf('/1.0/context.json') > -1 ||
this.externalResource.data['@context'].indexOf('/1.1/context.json') > -1 ||
this.externalResource.data['@context'].indexOf('/1/context.json') > -1 ) {
quality = 'native';

For a manifest which has an image context of 2.0, so I'm not sure why manifesto is returning "native"

The manifest I'm testing with is here: https://scta.info/iiif/graciliscommentary/lon/manifest

(maybe there is something wrong with the manifest. I'm not sure. Let me know if you see something.)

See the issue I've created here ProjectMirador/mirador#1831

jeffreycwitt added a commit to jeffreycwitt/manifesto that referenced this issue Feb 7, 2019
…eUri with default quality instead of native. Related to issue IIIF-Commons#47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant