Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for @graph keyword in manifest #25

Open
christopher-johnson opened this issue Sep 26, 2016 · 2 comments
Open

check for @graph keyword in manifest #25

christopher-johnson opened this issue Sep 26, 2016 · 2 comments

Comments

@christopher-johnson
Copy link

See UniversalViewer/universalviewer#385

@edsilv
Copy link
Member

edsilv commented Sep 26, 2016

Interesting... would it be possible to add your manifest as a test fixture with accompanying test?

https://github.com/viewdir/manifesto/tree/master/test/fixtures

Maybe just testing that it loads correctly. This would also ensure it doesn't break any other tests.

@christopher-johnson
Copy link
Author

@edsilv thank you for the reply. I added a test that checks if it loads correctly, and that resources can be read (I reused getManifestType() and getSequenceByIndex(0) ). See lines 117-124 in this file.
@graph_test.txt

All other tests still pass with the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants