Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup this repo to deploy to NPM #2

Closed
glenrobson opened this issue May 22, 2024 · 5 comments
Closed

Setup this repo to deploy to NPM #2

glenrobson opened this issue May 22, 2024 · 5 comments
Assignees

Comments

@glenrobson
Copy link

Change the following:

https://github.com/IIIF-Commons/manifesto-3d/blob/master/.github/workflows/release.yml

To deploy to NPM but not to overwrite the existing latest version at:

https://www.npmjs.com/package/manifesto.js

@edsilv to invite @luguenth to the NPM iiif-commons repo.

@luguenth luguenth self-assigned this May 23, 2024
@vincentmarchetti
Copy link

vincentmarchetti commented May 23, 2024

Lukas has renamed the package to manifesto3d in the package.json file (already committed) to support the deployment in npm without interfering with the existing manifesto.js npm package. I think with that change we can also change the version to a simpler npm semantic version. The version of the package is now "4.3.0-draft3dapi.0.5.0" ; the 4.3.0 refers to the latest manifesto.js version. I would propose setting the manifesto3d package.json version to 0.5.0; I leave it to Lukas to make that change if he agrees.

I will also recompile the modules with the new package name, commit them to a branch of iiif-commons/manifesto3d that I have created named kshell-dev. I will create a pull request to move those new compiled modules into master, and at that time we'll make sure we're all rowing in the same direction.

@luguenth
Copy link

Wasn't able to continue work here yesterday, so I try to set up a working NPM publishing pipeline today.
Regarding the versioning @vincentmarchetti, your proposal sounds good, and I'll reflect that in the package.json.

@luguenth
Copy link

I think everything should be in place now. The only thing I can't do is to set the NPM Token secret in the settings of the Repo. @glenrobson I think you can access the settings to set the secret. After setting them, a release with a new Tag should do the trick, I suppose.

@glenrobson
Copy link
Author

Notes from todays meeting:

  • Setup new NPM repo under the @IIIF organisation on npm.
  • Will only use this deployment for the duration of development look to end around June 2025.
  • Glen to ask Stephen to access the IIIF organization on NPM. Owner or admin. Invite all as members or as a Team

@vincentmarchetti
Copy link

Deployment to NPM was implemented at IIIF-Commons call on July 17 2024
The npm package name is @iiif/3d-manifesto-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants