-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reuse common schemas in lale.lib.sklearn #619
Comments
Started a file for this, only used by one operator so far: https://github.com/IBM/lale/blob/master/lale/lib/sklearn/_common_schemas.py |
|
Did this for lale.lib.imblearn: https://github.com/IBM/lale/blob/master/lale/lib/imblearn/_common_schemas.py |
Did this for lale.lib.autoai_libs: https://github.com/IBM/lale/blob/master/lale/lib/autoai_libs/_common_schemas.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Many operators in
lale.lib.sklearn
have similar schemas forfit
,predict
,transform
,predict_proba
, etc. Similarly, there are some hyperparameters that occur in many of the operators inlale.lib.sklearn
, such asrandom_state
,n_jobs
, etc. We could make our code base smaller and easier to maintain by defining such schemas only once in a file imported by each of the operators, and then plugging them in at the right place.We already do something like that for
lale.lib.aif360
:fit
andpredict
:lale/lale/lib/aif360/disparate_impact_remover.py
Lines 120 to 122 in 1f03397
lale/lale/lib/aif360/disparate_impact_remover.py
Line 131 in 1f03397
lale/lale/lib/aif360/disparate_impact_remover.py
Line 138 in 1f03397
The text was updated successfully, but these errors were encountered: