61 adopt env properties for dockerfile #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
Signed-off-by: Krzysztof Kaźmierczyk <[email protected]>
|
@kkazmierczyk something does not work, all of those chances are not reflected when I run a built image in Docker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61
I have tested it by modyfing the following line in dockefile to:
RUN pip install --extra-index-url https://test.pypi.org/simple/ --no-cache-dir javacore-analyser==2.1rc1This downloads 2.1rc1 version which includes changes from #60 .
To test it I would rerun creation and running container image with modified line mentioned.