Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture proc data to be able to generate minidump #156

Closed
swermin opened this issue Mar 1, 2024 · 4 comments
Closed

Capture proc data to be able to generate minidump #156

swermin opened this issue Mar 1, 2024 · 4 comments

Comments

@swermin
Copy link
Contributor

swermin commented Mar 1, 2024

Let me start by saying that this project has helped me bring core dump related stuff out of process and I love it!
The current setup we have is to generate a minidump from a core dump, which we use breakpads core2md

To be able to configure a proper minidump, some data from the /proc/$pid/ folder is needed. I have forked this project and added the changes needed for us to be able to support this flow. What it does is that it checks for a flag to see if needs to include proc info, if does then these steps are taken:

  • Grab the real pid out from the container with the crictl
  • Generate a folder inside the zip file
  • Add all files from proc that are needed

The process is repeated for every container in that pod.

I would love to contribute back this change into this project, is that something you all would be interested in having?

@No9
Copy link
Collaborator

No9 commented Mar 2, 2024

That sounds like an excellent feature - thanks for offering to share it back.
I need to resolve a side issue with the build system as we have disabled external actions but please open a PR when you are ready and we can start to land it.

@swermin
Copy link
Contributor Author

swermin commented Mar 6, 2024

The change is split in two repos, one for the libcrio and one for this repo.
I've created a PR for the libcrio part, here is the link: #156 (comment)

Second PR, for the actual core dump handler, is coming soon

@No9
Copy link
Collaborator

No9 commented Mar 6, 2024

Thanks - I've merged the PR with some additional house keeping around the workflows and released into crates.io as well as tagged in the repo - https://github.com/No9/libcrio/releases/tag/v2.1.0

@swermin
Copy link
Contributor Author

swermin commented Apr 1, 2024

Sorry for this taking more time than necessary. I had some trouble getting the whole feature tested well enough before I wanted to start a PR. I think I got a clean enough solution, so I have created this PR: #157

Please let me know if there is something that you want changed and I'll do that!

@swermin swermin closed this as completed Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants