Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate file names in generated zip files #144

Open
davisp opened this issue May 10, 2023 · 1 comment
Open

Duplicate file names in generated zip files #144

davisp opened this issue May 10, 2023 · 1 comment

Comments

@davisp
Copy link

davisp commented May 10, 2023

I've just started using core-dump-handler and have noticed zip files being generated with duplicate file names. I'm no Kubernetes expert so I can't decide if this is core-dump-handler or my kube config.

Archive:  b7dc0443-feb4-4662-80b2-18009a272281-dump-1683644775-<redacted>.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
      427  05-09-2023 15:06   b7dc0443-feb4-4662-80b2-18009a272281-dump-1683644775-<redacted>-dump-info.json
3164946432  05-09-2023 15:06   b7dc0443-feb4-4662-80b2-18009a272281-dump-1683644775-<redacted>.core
      874  05-09-2023 15:06   b7dc0443-feb4-4662-80b2-18009a272281-dump-1683644775-<redacted>-pod-info.json
     1043  05-09-2023 15:06   b7dc0443-feb4-4662-80b2-18009a272281-dump-1683644775-<redacted>-runtime-info.json
     2128  05-09-2023 15:06   b7dc0443-feb4-4662-80b2-18009a272281-dump-1683644775-<redacted>-ps-info.json
   318124  05-09-2023 15:06   b7dc0443-feb4-4662-80b2-18009a272281-dump-1683644775-<redacted>-0.log
      371  05-09-2023 15:06   b7dc0443-feb4-4662-80b2-18009a272281-dump-1683644775-<redacted>-0-image-info.json
        0  05-09-2023 15:06   b7dc0443-feb4-4662-80b2-18009a272281-dump-1683644775-<redacted>-0.log
      254  05-09-2023 15:06   b7dc0443-feb4-4662-80b2-18009a272281-dump-1683644775-<redacted>-0-image-info.json
---------                     -------
3165269653                     9 files

There are two containers in the pod so having two log files is obviously expected, although I'd expect one of the two to end with -1.log instead of two both ending in -0.log. Do you reckon that's an obvious configuration bug on my end or something with core-dump-handler?

@No9
Copy link
Collaborator

No9 commented May 12, 2023

Very strange alright
This is the line of code that gets the counter and container
https://github.com/IBM/core-dump-handler/blob/main/core-dump-composer/src/main.rs#L292
It's a rust language feature so there must be another reason why the value is getting squashed.
I'll build out the tests and see if I can recreate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants