Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement effective_area + docs example #107

Merged
merged 10 commits into from
Dec 19, 2023

Conversation

elizaleung830
Copy link
Contributor

Hi, i have added the example sciprt and reference data from the paper, hope this help!

@HelgeGehring HelgeGehring linked an issue Dec 15, 2023 that may be closed by this pull request
@HelgeGehring
Copy link
Owner

@elizaleung830 Thanks!

I've implemented the effective area (for $E_x$ / $E_y$ and $E_{xy}$) and tweaked the example a little.

Could you have a look if we need to adjust the resolution a bit more to converge with the numbers from the paper better?

Would also be great to have graphs for the other examples they provided in the paper, should just be an extra loop as you added already the data :)
We could also add the mode_transversality from the paper, that should be fraction_tm of the mode :)

After that the new example should be ready to go to the docs 🥳

@HelgeGehring HelgeGehring added the enhancement New feature or request label Dec 15, 2023
@HelgeGehring HelgeGehring changed the title Added reference data and script Implement effective_area + docs example Dec 15, 2023
@elizaleung830
Copy link
Contributor Author

Yes sure! I have added another graph as well as the mode transversality. However the tm_fraction doesn't seems to fit the data in paper very well, this might because of the slightly different defnition in the paper?

The resolution for neff and aeff in the code look good to me. However i realised that i probably need equation 1 and 2 as I will do some stimulations on waveguide as well. Would it be possible to implment them as well?

Thanks a lot!

@HelgeGehring HelgeGehring merged commit 9611709 into HelgeGehring:main Dec 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculation of effective mode area or nonlinear coefficent
2 participants