feat: auditlog #157

deepakdinesh1123 · 2024-03-18T02:40:35Z

fixes #166

shahharsh176 · 2024-04-03T12:18:40Z

@deepakdinesh1123 we can remove the enterprise folder as now auditlog is shifted to apps

shahharsh176 · 2024-04-03T12:19:50Z

backend/src/zelthy/api/platform/tenancy/v1/urls.py

@@ -15,6 +15,7 @@
 from zelthy.api.platform.packages.v1 import urls as packages_v1_urls
 from zelthy.api.platform.tasks.v1 import urls as tasks_v1_urls
 from zelthy.api.platform.codeassist.v1 import urls as codeassist_v1_urls
+from zelthy.api.platform.audit.v1 import urls as audit_v1_urls


audit can be changed to auditlog

shahharsh176 · 2024-04-03T12:24:31Z

backend/src/zelthy/api/platform/tenancy/v1/urls.py

@@ -57,5 +58,6 @@
 re_path(r"^(?P<app_uuid>[\w-]+)/packages/$", include(packages_v1_urls)),
 re_path(r"^(?P<app_uuid>[\w-]+)/tasks/", include(tasks_v1_urls)),
 re_path(r"^(?P<app_uuid>[\w-]+)/code-assist/", include(codeassist_v1_urls)),
+ re_path(r"^(?P<app_uuid>[\w-]+)/audit/", include(audit_v1_urls)),


shahharsh176 · 2024-04-03T12:30:28Z

backend/src/zelthy/api/platform/audit/v1/views.py

+from .serializers import AuditLogSerializerModel
+
+
+class AuditLogViewAPIV1(ZelthyGenericPlatformAPIView, ZelthyAPIPagination):


here we can attach set_app_schema_path decorator. Refer to the task APIs or tenancy views

shahharsh176 · 2024-04-03T12:33:37Z

backend/src/zelthy/api/platform/audit/v1/views.py

+ search = request.GET.get("search", None)
+ columns = get_search_columns(request)
+ connection.set_tenant(tenant)
+ with connection.cursor() as c:


when we attach set_app_schema_path, we don't need to change the connection explicitly

shahharsh176 · 2024-04-04T04:23:03Z

backend/src/zelthy/apps/auditlog/__init__.py

@@ -0,0 +1,3 @@
+# from importlib.metadata import version
+
+# __version__ = version("django-auditlog")


if this is not need needed pls remove the commented code

shahharsh176 · 2024-04-04T04:30:08Z

backend/src/zelthy/apps/auditlog/models.py

+ changes = models.JSONField(null=True, verbose_name=_("change message"))
+ tenant_actor = models.ForeignKey(
+ to="appauth.AppUserModel",
+ on_delete=models.DO_NOTHING,


we can change the on_delete to models.SET_NULL

shahharsh176 · 2024-04-04T04:30:22Z

backend/src/zelthy/apps/auditlog/models.py

+ )
+ platform_actor = models.ForeignKey(
+ to="platformauth.PlatformUserModel",
+ on_delete=models.DO_NOTHING,


change the on_delete to models.SET_NULL

shahharsh176 · 2024-04-04T04:43:51Z

backend/src/zelthy/apps/auditlog/models.py

+ kwargs.setdefault("additional_data", get_additional_data())
+ db = instance._state.db
+ try:
+ obj = ObjectStore.objects.get(object_uuid=instance.object_uuid)


also handle the case where objectstore doesn't contain the object with given instance.object_uuid, in this case code shouldn't break, object_ref can be None in that case

shahharsh176 · 2024-04-04T04:50:25Z

backend/src/zelthy/apps/exportjob/models.py

@@ -0,0 +1,12 @@
+from django.db import models


please remove the exportjob as of now

shahharsh176 · 2024-04-04T04:51:15Z

backend/src/zelthy/config/urls_public.py

- urlpatterns += [
- path("__debug__/", include("debug_toolbar.urls")),
- ]
+ # urlpatterns += [


pls revert this change

shahharsh176 · 2024-04-04T04:51:24Z

backend/src/zelthy/config/urls_tenants.py

@@ -7,12 +7,12 @@
 re_path(r"^", include("zelthy.apps.appauth.urls")),
 re_path(r"api/auth/", include("knox.urls")),
 re_path(r"api/", include("zelthy.api.app_auth.urls")),
- path("__debug__/", include("debug_toolbar.urls")),
+ # path("__debug__/", include("debug_toolbar.urls")),


pls revert this change

shahharsh176 · 2024-04-04T04:51:32Z

backend/src/zelthy/config/urls_tenants.py

- urlpatterns += [
- path("__debug__/", include("debug_toolbar.urls")),
- ]
+ # urlpatterns += [


pls revert this change

shahharsh176 · 2024-04-12T09:50:01Z

@deepakdinesh1123 should we change "api/platform/auditlog" folder to api/platform/auditlogs to be in sync with app name auditlogs ?

add: audit logs unused build removed

kc-diabeat · 2024-05-03T10:05:33Z

frontend/src/pages/app/components/Layout/SideMenu.jsx

@@ -106,6 +106,46 @@ export default function SideMenu() {
 Packages
 </span>
 </NavLink>
+ {/* <NavLink


Pls remove unnecessary commented code

kc-diabeat · 2024-05-03T10:07:22Z

frontend/src/pages/appAccessLogs/slice/index.js

@@ -0,0 +1,130 @@
+import { createSlice } from '@reduxjs/toolkit';
+
+export const appAccessLogsSlice = createSlice({


Accesslog related code should not be included in this PR.

kc-diabeat · 2024-05-03T10:21:00Z

backend/src/zelthy/apps/auditlogs/LICENSE

@@ -0,0 +1,20 @@
+The MIT License (MIT)


Lets have a readme file in this folder where we detail out:

which version of auditlog library we have taken

what changes have we made

overall rationale

How is it being used, how to exclude model, fields, etc.
Also include a section in Docs

* refactor: auditlog fe * build: 1.1.1 * remove: license file

deepakdinesh1123 requested a review from shahharsh176 March 18, 2024 02:40

deepakdinesh1123 force-pushed the auditlog branch 2 times, most recently from f72ec11 to 5252e5e Compare April 3, 2024 10:16

shahharsh176 requested changes Apr 3, 2024

View reviewed changes

shahharsh176 requested changes Apr 4, 2024

View reviewed changes

deepakdinesh1123 force-pushed the auditlog branch from 47c7ef0 to e291820 Compare April 9, 2024 13:22

deepakdinesh1123 force-pushed the auditlog branch from 143ce76 to debc209 Compare May 3, 2024 03:55

auditlog added

8dc8388

add: audit logs unused build removed

deepakdinesh1123 force-pushed the auditlog branch from cf66414 to 8dc8388 Compare May 3, 2024 05:41

shahharsh176 changed the title ~~auditlog added to enterprise folder~~ feat: auditlog May 3, 2024

shahharsh176 requested a review from kc-diabeat May 3, 2024 08:16

session security added

6e51cde

kc-diabeat reviewed May 3, 2024

View reviewed changes

deepakdinesh1123 and others added 4 commits May 3, 2024 20:01

readme added for auditlogs

a42aa40

django-auditlog library version updated

cadddc1

refactor: auditlog fe (#213)

8342fb9

* refactor: auditlog fe * build: 1.1.1 * remove: license file

remove: extra build and mock files (#215)

d904269

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: auditlog #157

feat: auditlog #157

deepakdinesh1123 commented Mar 18, 2024 •

edited

shahharsh176 commented Apr 3, 2024

shahharsh176 Apr 3, 2024

shahharsh176 Apr 3, 2024

shahharsh176 Apr 3, 2024

shahharsh176 Apr 3, 2024

shahharsh176 Apr 4, 2024

shahharsh176 Apr 4, 2024

shahharsh176 Apr 4, 2024

shahharsh176 Apr 4, 2024

shahharsh176 Apr 4, 2024

shahharsh176 Apr 4, 2024

shahharsh176 Apr 4, 2024

shahharsh176 Apr 4, 2024

shahharsh176 commented Apr 12, 2024 •

edited

kc-diabeat May 3, 2024

kc-diabeat May 3, 2024

kc-diabeat May 3, 2024

		from .serializers import AuditLogSerializerModel


		class AuditLogViewAPIV1(ZelthyGenericPlatformAPIView, ZelthyAPIPagination):

		@@ -0,0 +1,3 @@
		# from importlib.metadata import version

		# __version__ = version("django-auditlog")

		@@ -0,0 +1,130 @@
		import { createSlice } from '@reduxjs/toolkit';

		export const appAccessLogsSlice = createSlice({

feat: auditlog #157

Are you sure you want to change the base?

feat: auditlog #157

Conversation

deepakdinesh1123 commented Mar 18, 2024 • edited

shahharsh176 commented Apr 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shahharsh176 commented Apr 12, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deepakdinesh1123 commented Mar 18, 2024 •

edited

shahharsh176 commented Apr 12, 2024 •

edited