Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some improvements #7

Open
eksklawa opened this issue Aug 4, 2021 · 0 comments
Open

some improvements #7

eksklawa opened this issue Aug 4, 2021 · 0 comments

Comments

@eksklawa
Copy link

eksklawa commented Aug 4, 2021

first of all I need to say it is great job, thank you!

do you know if there is a quick way to check what changed between CIS benchmarks for Redhat/Centos 8.2 (supported by your scripts now) and Redhat/Centos 8.4 - to change/add/remove needed stuff?

Btw. to speedup some tasks execution it would be worth to tune some of them, for example in 1.1.18.yml I recommend changing task:

  - name: 1.1.18 - Ensure sticky bit is set on all world-writable directories - changed_when false
    shell: df --local -P | awk {'if (NR!=1) print $6'} | xargs -I '{}' find '{}' -xdev -type d -perm -0002
    register: shell_output
    changed_when: false

with

  - name: 1.1.18 - Ensure sticky bit is set on all world-writable directories - changed_when false
    shell: df --local -P | awk {'if (NR!=1) print $6'} | xargs -I '{}' find '{}' -xdev -type d \( -perm -0002 -a ! -perm -1000 \)
    register: shell_output
    changed_when: shell_output.stdout_lines | length > 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant