Basic inputminted support
#3541
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jojo2357
requested review from
HannahSchellekens,
stenwessel,
PHPirates and
slideclimb
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
PHPirates
requested changes
May 6, 2024
There was a problem hiding this comment.
Thanks, this is in the right direction! Since the list is rather long and likely to change, I think we should get it on the fly. A recent example is LatexCommandLineOptionsCache. The issue with the cache was that I did not want to block the UI when filling the cache, so it is done in the background, so the first time it does not show. Not sure if that is necessary for autocompletion.
|
How about hardcoding the partial list from Overleaf and then fetching the rest on the fly? That way even without pygments there will be some autofill |
|
Agree, a small default list as backup would be fine |
|
These changes will take some time. Drafting for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3540
Right now, it has a hardcoded list, cannot find custom lexers, and does not enforce extension correctness. The per-language extensions are all in there. It could be refactored into an enum, but for future proofing I am leaving it as a class.
Let me know if I am on the right track here