-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change or Add inpainting to support new InpaintModelConditioning
from ComfyUI
#176
Comments
I tested it a bit, the new node seems to work better at both low and high denoise. |
Three only problem I see with converting is that existing saved settings will no longer work. I recently re-ran a bunch of old generations on newer SDXL models, which is something I do occasionally. I'm not sure how common this is. I can't personally test this change without it being on a running worker; I've never actually used ComfyUI except via Horde, and I'm also out of runpod credit because I spent 2.5 months worth last month 😢. |
I'm OK with switching. Unfortunately maintaining this level of backwards compatibility is not something we can do as a volunteer service. Backwards compatibility is expensive |
As of comfyanonymous/ComfyUI@10f2609, ComfyUI now supports a new kind of inpainting which purportedly supports lower denoise strengths for inpainting-specific models (as originally proposed here: comfyanonymous/ComfyUI#2501).
@Efreak @spinagon @db0
The text was updated successfully, but these errors were encountered: