Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horde-bridge script proceeds to start worker even if downloads fail #92

Open
tazlin opened this issue Jan 18, 2024 · 4 comments
Open

horde-bridge script proceeds to start worker even if downloads fail #92

tazlin opened this issue Jan 18, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@tazlin
Copy link
Member

tazlin commented Jan 18, 2024

While SD models are not a huge problem, control nets and upscalers being missing would cause runtime problems.

@tazlin tazlin added the bug Something isn't working label Jan 18, 2024
@db0
Copy link
Member

db0 commented Jan 18, 2024

I send a new change to the niter branch to handle this. Can you test on windows? On linux it's OK

@CIB
Copy link
Contributor

CIB commented Sep 16, 2024

It is also a problem for SD models, as for some reason it will try to pop jobs with the model that failed to download. It'd also be nice if the "top N models" command would exclude models that require an API key, if no API key is specified.

@arcaria
Copy link

arcaria commented Sep 17, 2024

@tazlin @db0
Why not just hardcode an API key into the worker when none is specified by the user?
The workers do not currently inform the users why a lora failed to download, only that it did

@tazlin
Copy link
Member Author

tazlin commented Sep 17, 2024

@tazlin @db0

Why not just hardcode an API key into the worker when none is specified by the user?

The workers do not currently inform the users why a lora failed to download, only that it did

Sharing accounts is explicitly against the CivitAI terms of service and they have greatly expanded their crackdown on requiring logins lately. Committing tokens or password to a git repo is a very bad practice at best and at worst would constitute a flagrant ToS violation which could lead to some sort of drastic action on their part.

As for the better communication of the reason to end users, we could look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants