Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Restructure] Fixing Resource Page and broadcast flow #976

Open
Kajol-Kumari opened this issue May 27, 2024 · 11 comments
Open

[Restructure] Fixing Resource Page and broadcast flow #976

Kajol-Kumari opened this issue May 27, 2024 · 11 comments
Assignees
Labels
backend This issue is related to backend frontend This issue is related to frontend gssoc GSSoC'24 Label NO MORE ASSIGNMNET This issue won't be assigned to anybody else

Comments

@Kajol-Kumari
Copy link
Member

Description

The current resource creation flow is wrong, the creation of resource should create a new braodcast, instead of a resource, with the isApproved flag set to false by default -> admins should approve these braodcasts using manage broadcasts page and then it should appear on the Broadcast page of frontend.

Issue Breakdown

  1. Introduce isApproved flag in broadcats model. Refactor the resource form so that a new broadcast gets created on successful submission, with isApproved set to false.
  2. Manage broadcast page will fetch all approved/non-approved broadcasts
  3. There should be 2 more buttons on manage broadcasts card - approve and reject
Screenshot 2024-05-27 at 9 08 27 PM 4. add a filter of `isApproved=true` in the Broadcast and all broadcast page.
@Kajol-Kumari Kajol-Kumari added frontend This issue is related to frontend backend This issue is related to backend level2 Bug fixing, adding small features. gssoc GSSoC'24 Label labels May 27, 2024
@Kajol-Kumari
Copy link
Member Author

This issue will be broken down in 4 issues like mentioned above, please claim one issue at a time mentioning the point number.

@SwayamRana808
Copy link
Contributor

SwayamRana808 commented May 31, 2024

i have doubt " the creation of resource should create a new broadcast, instead of a resource" ...
so we will not use resource schema and will use broadcast schema and post methods like used in admin "add broadcast page" in home>resource page and change the resource form like broadcast form?
@Kajol-Kumari

@SwayamRana808
Copy link
Contributor

"Manage broadcast page will fetch all approved/non-approved broadcasts" if get all broadcast how we will know which one is approved and which one not ?
1>There should be 2 more buttons on manage broadcasts card - approve and reject--
should we use one button approve if not and reject if not approved?

@Kajol-Kumari
Copy link
Member Author

oadcast, instead of a resource" ...
so we will not use resource schema and will use broadcast schema and post methods like used in admin "add broadcast page" in home>resource page and change the resource form like broadcast form?

yes, @SwayamRana808

@Kajol-Kumari
Copy link
Member Author

"Manage broadcast page will fetch all approved/non-approved broadcasts" if get all broadcast how we will know which one is approved and which one not ? 1>There should be 2 more buttons on manage broadcasts card - approve and reject-- should we use one button approve if not and reject if not approved?

when a new broadcast gets added, we should have isApproved flag set to false by default and only after approval from Manage Broadcast of admin panel, it should show in broadcast/all broadcast page of the website.

Note - this issue will be broken down into 3 separate issues

@shivamgaur99
Copy link
Contributor

shivamgaur99 commented Jun 2, 2024

@Kajol-Kumari i would like to work on that issue, if @SwayamRana808 want to work you can assign him

@Hemu21
Copy link
Contributor

Hemu21 commented Jun 2, 2024

@Kajol-Kumari as you said this issue is breakdown into 3 so can you please assign me one. other 2 to above asked ones. Here we 3 asked and it is divided into 3. so, can you please assign me one issue from this issue.

@Kajol-Kumari
Copy link
Member Author

@SwayamRana808 / @shivamgaur99 / @Hemu21 i have listed the issue breakdown in issue description, whichever part u want to claim, just create a new issue for that as u folks are first one to comment so ideally it would get assigned to u, i hope u three claim one each

@Hemu21
Copy link
Contributor

Hemu21 commented Jun 3, 2024

@Kajol-Kumari can you please assign me the issue 3.

@shivamgaur99
Copy link
Contributor

@Kajol-Kumari, please assign me issue 1.

@SwayamRana808
Copy link
Contributor

please assign me the issue 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend This issue is related to backend frontend This issue is related to frontend gssoc GSSoC'24 Label NO MORE ASSIGNMNET This issue won't be assigned to anybody else
Projects
None yet
Development

No branches or pull requests

4 participants