-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement]: Recommend/Warn Java 8 for older Minecraft versions in script #479
Comments
Heya Kreezxil, ohhhh so now we have the reverse situation at hand, did I understand that correctly? |
Related to this: #445 |
Yes, apparently this is the UNO reverse card. |
Heya Kreezxil, if I remember correctly, you usually have multiple Java installations available on your machine. I'd like some feedback from people's environments other than my own (sanity check). Could you run the following command and post the return from it here?
It should list all Java installations available in the system path and print their versions. Trying to determine whether that would be a viable way to discover available Java installations in a bash-script. Cheers |
I've actually done a Linux reset since talking about that, because I experimented way too much, however, I have java in two locations and your command produced the following output.
|
Thanks for the feedback. I'll run some more tests on my end soonish. |
I responded too quick, I check my /usr/lib/jvm and it did not detect my other installations of Java 8 and Java 22. |
Java checks are available as of https://github.com/Griefed/ServerPackCreator/releases/tag/6.0.0-alpha.3 Checks are based on the info from MultiMC and the info Chorb posted somewhere, as in MC 1.16 and older can use Java 8 and 11, everything else has a "minimum required" check. This should aleviate at least a portion of problems on the users side for their Java version. |
Check out the latest alpha build: https://github.com/Griefed/ServerPackCreator/releases/tag/6.0.0-alpha.11 It not only has Java compatibility checks, which were added in alpha 3, but also automated Java installation based on the Java version recommended by Mojang themselves. I'd appreciate some tests on this. :) |
Available as of 6.0.0 |
What happened?
Now that Minecraft and server pack creator are well beyond the Java 8 packs, especially 1.12.2, we have an interesting issue happening.
Most users have a newer than java 8 install on their systems. If they try run install.sh or .ps1 using the not java 8 java the libaries folder will fail to extract.
This was pointed out to me with my https://www.curseforge.com/minecraft/modpacks/world-of-dragons
server pack. Took a fair bit to understand what was happening.
Since I"m pack and on again off again mod dev, i naturally have a lot of javas on hand so, once I told variables text to use java8 (that's what i called my java 8 binary), the library extracted.
What did you expect to happen?
Through no fault of SPC, I did kind of expect the installer script to actually extract libraries folder, but thinking about it ... I think I'd want it to tell the user that it expects a different version of java to do its thing. this may be too much to ask for and yes I know as each day marches on, less and less do we see java 8 servers running.
Version
4.3.2 and 5.0.0-beta.10
Relevant log output
Anything else you would like to add?
Keep up the good work, and I'm not holing my breath as stated above.
If you are using the webservice, in which browers did you encounter this bug?
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: