Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: adds sqlness test for TTL #5063

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

test: adds sqlness test for TTL #5063

wants to merge 4 commits into from

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Nov 27, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Close #5045

What's changed and what's your intention?

Adds sqlness tests for TTL behavior including normal table, metric engine table, and database TTL.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@killme2008 killme2008 requested a review from a team as a code owner November 27, 2024 12:29
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Nov 27, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.79%. Comparing base (8bdef77) to head (6e81825).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5063      +/-   ##
==========================================
- Coverage   84.03%   83.79%   -0.24%     
==========================================
  Files        1156     1156              
  Lines      216327   216327              
==========================================
- Hits       181783   181267     -516     
- Misses      34544    35060     +516

lyang24
lyang24 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@lyang24 lyang24 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added sqlness test is very useful, and the result LGTM, thank you. Maybe we can add an additional case with combination of database ttl and metric engine reopen.

@v0y4g3r
Copy link
Contributor

v0y4g3r commented Nov 28, 2024

@WenyXu Looks like schema cache is missing in build_fundamental_cache_registry so the cache invalidation does not take effect

greptimedb/src/cache/src/lib.rs

Line 43 in 24612f6

pub fn build_fundamental_cache_registry(kv_backend: KvBackendRef) -> CacheRegistry {

@killme2008
Copy link
Contributor Author

killme2008 commented Nov 28, 2024 •
edited
Loading

@WenyXu Looks like schema cache is missing in build_fundamental_cache_registry so the cache invalidation does not take effect

greptimedb/src/cache/src/lib.rs

Line 43 in 24612f6

pub fn build_fundamental_cache_registry(kv_backend: KvBackendRef) -> CacheRegistry {

We need more rigorous code reviews.

@v0y4g3r
Copy link
Contributor

v0y4g3r commented Nov 28, 2024

@WenyXu Looks like schema cache is missing in build_fundamental_cache_registry so the cache invalidation does not take effect

greptimedb/src/cache/src/lib.rs

Line 43 in 24612f6

pub fn build_fundamental_cache_registry(kv_backend: KvBackendRef) -> CacheRegistry {

We need more rigorous code reviews.

Let me fix that.

@v0y4g3r v0y4g3r mentioned this pull request Nov 28, 2024
Open
@WenyXu
Copy link
Member

WenyXu commented Nov 28, 2024

@WenyXu Looks like schema cache is missing in build_fundamental_cache_registry so the cache invalidation does not take effect

greptimedb/src/cache/src/lib.rs

Line 43 in 24612f6

pub fn build_fundamental_cache_registry(kv_backend: KvBackendRef) -> CacheRegistry {

There are two levels of cache: the upper-level cache, SchemaNameValue, and the lower-level cache, KeyValue. The SchemaNameValue cache is omitted here because it is unnecessary; the KeyValue cache alone is sufficient.

@v0y4g3r v0y4g3r mentioned this pull request Nov 28, 2024
Open
3 tasks
@killme2008
Copy link
Contributor Author

Waits for #5067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia left review comments

@lyang24 lyang24 lyang24 approved these changes

@fengjiachun fengjiachun Awaiting requested review from fengjiachun

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrates tests for TTL behavior
5 participants
@killme2008 @v0y4g3r @WenyXu @waynexia @lyang24