Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check manifest file when createing table #1833

Closed
waynexia opened this issue Jun 26, 2023 · 4 comments
Closed

Check manifest file when createing table #1833

waynexia opened this issue Jun 26, 2023 · 4 comments
Labels
C-enhancement Category Enhancements

Comments

@waynexia
Copy link
Member

What type of enhancement is this?

Tech debt reduction

What does the enhancement do?

Create table may fail and will be retried by procedure. To make sure manifest files are correct we should check its content if there are any.

Implementation challenges

No response

@waynexia waynexia added the C-enhancement Category Enhancements label Jun 26, 2023
@NiwakaDev
Copy link
Collaborator

I'd like to work on this issue if you don't mind. If so, Do you have any guidelines for addressing this issue?

@waynexia
Copy link
Member Author

waynexia commented Jul 4, 2023

@evenyag maybe you have some thoughts?

@evenyag
Copy link
Contributor

evenyag commented Jul 4, 2023

I haven't figured out a clear solution for this. What's more, I plan to refactor manifests and table engine in #1869 which might fix this issue. Let's postpone this.

@fengjiachun fengjiachun moved this to Todo in GreptimeDB v0.4 Jul 10, 2023
@killme2008
Copy link
Contributor

Looks like we don't need to fix this in 0.4, because we removed the table manifest and replaced it with metasrv management.

@github-project-automation github-project-automation bot moved this from Todo to Done in RegionServer Sep 1, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in GreptimeDB v0.4 Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements
Projects
Status: Done
Status: Done
Development

No branches or pull requests

4 participants