Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layers physically move when being transferred to a new folder which has a different transform #861

Open
Keavon opened this issue Nov 19, 2022 · 6 comments · May be fixed by #2212
Open

Layers physically move when being transferred to a new folder which has a different transform #861

Keavon opened this issue Nov 19, 2022 · 6 comments · May be fixed by #2212
Labels
Good First Issue Good for newcomers Paper Cut A small UX annoyance we should strive to improve

Comments

@Keavon
Copy link
Member

Keavon commented Nov 19, 2022

This requires some knowledge of linear algebra and transforms, for example by people who have experience with computer graphics or gamedev.

#2177 can be useful reference for how transforms are modified for cross-scope movement.

@Keavon Keavon added Feature Good First Issue Good for newcomers labels Nov 19, 2022
@Keavon Keavon added P-High Paper Cut A small UX annoyance we should strive to improve and removed P-Medium labels Dec 27, 2022
@0HyperCube 0HyperCube moved this to Sprint 24 Goals in Task Board Mar 18, 2023
@Keavon Keavon removed the Available label May 31, 2023
@Keavon Keavon moved this to Available in Task Board May 31, 2023
@Keavon Keavon moved this from Always Up for Grabs to Short-Term in Task Board May 31, 2023
@Keavon Keavon removed the P-High label May 31, 2023
@lyingpasta
Copy link

Hey @Keavon Is this still on ? I could take it if it's the case

@Keavon
Copy link
Member Author

Keavon commented Nov 6, 2024

@lyingpasta go for it! This'll be valuable to solve.

@lyingpasta
Copy link

lyingpasta commented Nov 11, 2024

@Keavon can you give some example of what it's intended for this behavior ? Do we need the transform property of the parent layer to be applied to all it's children or compute a new transform based on the original one and the parent's ?

@Keavon
Copy link
Member Author

Keavon commented Nov 12, 2024

@lyingpasta For each layer that's dragged out of a certain folder, it should have a transform applied to it that puts it back into its original transformation as if the user had dragged it back there (and resized/scaled/skewed it). If multiple layers are dragged out of a certain folder, that applies individually to each one of them.

@lyingpasta
Copy link

It seems like it's actually the case, I created 3 layers one of them with a scaling transform when I drag one layer to it, the transform applies to it also, then I drag it back out and it goes back to its original state. Isn't this what we need ?

@Keavon
Copy link
Member Author

Keavon commented Nov 13, 2024

It needs to do exactly not that. Any layer rearranged in the layer panel should never change its transform within the canvas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers Paper Cut A small UX annoyance we should strive to improve
Projects
Status: Short-Term
Development

Successfully merging a pull request may close this issue.

2 participants