Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export graphs in a single PDF file #451

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

atilaajones
Copy link
Contributor

The issue #430 will be addressed in this branch. Its solution should also include the following functionality:

  • In the export submenu of the tree's context menu there will be a function to export a list of graphs (.g6 or .txt) in a single PDF.
  • When selected, a dialog box will open asking the user for the number of graphs to be exported and the number of graphs to be displayed on each line of the file.
  • Next, a new window will be used to select the file name and save location (as already done in the other exports).
  • Pay attention to input validation.

Closes #430

@atilaajones atilaajones added enhancement New feature or request external user External user issue labels Dec 11, 2023
@fsoupimenta fsoupimenta reopened this Apr 17, 2024
@fsoupimenta fsoupimenta removed enhancement New feature or request external user External user issue labels May 8, 2024
@fsoupimenta fsoupimenta marked this pull request as ready for review May 8, 2024 18:48
@atilaajones
Copy link
Contributor Author

atilaajones commented May 8, 2024

@fsoupimenta
The tool is well implemented. But there are some observations:

  1. When trying to export an invalid graph the software freezes, for example the SomeGraphs.g6 file.
  2. There should be a check to prevent (#rows) X (#columns) from being less than the number of graphs.
  3. I also observed unexpected behavior when exporting a list of graphs with a single graph.

On closer inspection, I noticed that the correct thing to do is for the user to choose only the number of columns, or rather the number of graphs in each row. This way, the plotting is done in a row, which must be broken whenever it reaches the number chosen by the user. This solves problems (2) and (3) together. See the second topic of the PR description.

Finally, I think that in the tree menu, we can rename the exports to: Single file - image (.pdf) AND Multiple files - image (.pdf).

@fsoupimenta
Copy link
Member

fsoupimenta commented May 24, 2024

@fsoupimenta The tool is well implemented. But there are some observations:

  1. When trying to export an invalid graph the software freezes, for example the SomeGraphs.g6 file.
  2. There should be a check to prevent (#rows) X (#columns) from being less than the number of graphs.
  3. I also observed unexpected behavior when exporting a list of graphs with a single graph.
  1. The problem of exporting files containing invalid graphs has been resolved.

  2. The limitation of rows and columns has been implemented, where the value must be greater than 0. If the user enters a character that is not a number or a value less than or equal to 0, a following warning screen will be displayed:

    Screenshot_94

Note

  1. The aesthetics of the export have been improved so that the graphs are similar to those displayed in the software. In addition, a logic has been implemented where the size of the plot is proportional to the number of rows and columns, in order to improve the visualization of the graphs in some cases. Below are examples:
2x2 5x5 7x7
2x2 5x5 7x7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Export graphs in a single PDF file
3 participants