Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

[Reminder] Update the deploy/k8s.yaml "args" with "taint" flag when releasing new image. #13

Open
yuwenma opened this issue Apr 17, 2019 · 1 comment

Comments

@yuwenma
Copy link
Contributor

yuwenma commented Apr 17, 2019

Story:
I built my own node-termination-handler from master/head and tried to use deploy/k8s.yaml to bring up the node-termination-handler pods. I encountered the error below:

I0417 20:56:13.190654   40157 main.go:109] Using kube config: &{Host:https://10.11.240.1:443 APIPath: ContentConfig:{AcceptContentTypes: ContentType: GroupVersion:<nil> NegotiatedSerializer:<nil>} Username: Password: BearerToken:eyJhbGciOiJSUzI1NiIsImtpZCI6IiJ9.eyJpc3MiOiJrdWJlcm5ldGVzL3NlcnZpY2VhY2NvdW50Iiwia3ViZXJuZXRlcy5pby9zZXJ2aWNlYWNjb3VudC9uYW1lc3BhY2UiOiJrdWJlLXN5c3RlbSIsImt1YmVybmV0ZXMuaW8vc2VydmljZWFjY291bnQvc2VjcmV0Lm5hbWUiOiJub2RlLXRlcm1pbmF0aW9uLWhhbmRsZXItdG9rZW4tNnZtYzYiLCJrdWJlcm5ldGVzLmlvL3NlcnZpY2VhY2NvdW50L3NlcnZpY2UtYWNjb3VudC5uYW1lIjoibm9kZS10ZXJtaW5hdGlvbi1oYW5kbGVyIiwia3ViZXJuZXRlcy5pby9zZXJ2aWNlYWNjb3VudC9zZXJ2aWNlLWFjY291bnQudWlkIjoiMjM1YjFkN2YtNjE0OS0xMWU5LTgwYzItNDIwMTBhODAwMWNmIiwic3ViIjoic3lzdGVtOnNlcnZpY2VhY2NvdW50Omt1YmUtc3lzdGVtOm5vZGUtdGVybWluYXRpb24taGFuZGxlciJ9.W_GIvwGLbd7KIdgDWnRk2dQQJaXoIk0LbyzMcLLWMyS45SOIl8baSPGVMYiMMzcoCWUk03Z7fXIKWtzB2lSxQ7FVw_KAPZW3_JI4PBEI9jb19GZmbF7dsiANFKulArFi0WUGGB-LJ9vPjFTYaKIE3AknQsarql5furB807Pl-TVtwLjw10k6voLnS9sB3EHEW2rV5tHK6IANRF50QVBbyBUgy6rqqEXdK6bE1OCykIhr_qNE31wALMXG0ukemHg33GkSDHHD_M5FrVffFEqlzp3ycViiF_gLvoT7lZhOia0Zevyo7L-_XuW8v4LwR40I8LOqowvEN3wz6gOjP1V-dw Impersonate:{UserName: Groups:[] Extra:map[]} AuthProvider:<nil> AuthConfigPersister:<nil> ExecProvider:<nil> TLSClientConfig:{Insecure:false ServerName: CertFile: KeyFile: CAFile:/var/run/secrets/kubernetes.io/serviceaccount/ca.crt CertData:[] KeyData:[] CAData:[]} UserAgent: Transport:<nil> WrapTransport:<nil> QPS:0 Burst:0 RateLimiter:<nil> Timeout:0s Dial:<nil>}

F0417 20:56:13.191863   40157 main.go:66] Must specify one of taint or annotation

@mindprince helped on debugging this and we noticed some new flags are added in recent code but the example in deploy/k8s.yaml is still based on an old version. (It works with the old version because the change is not included. But will break when release a new image.)

Suggestion:
This issue is a reminder that when releasing a new image, we also need to update the containers/args with flag "-taint" or "-annotation", otherwise the yaml won't work.

e.g.

-image: gcr.io/node-termination-handler@sha256:NEW_SHA
 name: node-termination-handler
  command: ["./node-termination-handler"]
   args: ["--logtostderr", "--exclude-pods=$(POD_NAME):$(POD_NAMESPACE)", "-v=10", "-taint=blah:blah:blah"]
@yuwenma
Copy link
Contributor Author

yuwenma commented May 1, 2019

/assign @yuwenma

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant