Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing google-auth-* in setup.py #67

Closed
khoinguyen19k8 opened this issue May 1, 2024 · 0 comments · Fixed by #70 · May be fixed by #69
Closed

Missing google-auth-* in setup.py #67

khoinguyen19k8 opened this issue May 1, 2024 · 0 comments · Fixed by #70 · May be fixed by #69

Comments

@khoinguyen19k8
Copy link

khoinguyen19k8 commented May 1, 2024

Hi,
Recently this PR ( #62 ) added two new dependencies:

  • google-auth==2.17.0
  • google-auth-httplib2>=0.2.0.

They are added to requirements.txt but not setup.py. This caused Module not Found error for any downstream packages trying to use this package. Please consider doing so.

@khoinguyen19k8 khoinguyen19k8 changed the title Missing required packages in setup.py Missing google-auth-* in setup.py May 1, 2024
stanhu added a commit to stanhu/gcs-oauth2-boto-plugin that referenced this issue May 1, 2024
GoogleCloudPlatform#62
added these dependencies to `requirements.txt`, but neglected to
include them in `setup.py`. As a result, installing `pip install
gsutil` doesn't automatically install these dependencies, resulting
in:

```
File "/usr/local/lib/python3.9/site-packages/gcs_oauth2_boto_plugin/oauth2_client.py", line 57, in <module>
  from google_auth_httplib2 import Request as GoogleAuthRequest
ModuleNotFoundError: No module named 'google_auth_httplib2'
```

Closes GoogleCloudPlatform#67
stanhu added a commit to stanhu/gcs-oauth2-boto-plugin that referenced this issue May 1, 2024
GoogleCloudPlatform#62
added these dependencies to `requirements.txt`, but neglected to
include them in `setup.py`. As a result, installing `pip install
gsutil` doesn't automatically install these dependencies, resulting
in:

```
File "/usr/local/lib/python3.9/site-packages/gcs_oauth2_boto_plugin/oauth2_client.py", line 57, in <module>
  from google_auth_httplib2 import Request as GoogleAuthRequest
ModuleNotFoundError: No module named 'google_auth_httplib2'
```

Closes GoogleCloudPlatform#67

Signed-off-by: Stan Hu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment