Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method get_playbook does not return parameter type #208

Open
yashbadani-google opened this issue Jul 16, 2024 · 2 comments
Open

Method get_playbook does not return parameter type #208

yashbadani-google opened this issue Jul 16, 2024 · 2 comments
Assignees
Labels
bug Something isn't working Generative Features Any features that utilizes LLMs Pending Bug Fix Playbooks

Comments

@yashbadani-google
Copy link

While calling the create_playbook using the playbook object from get_playbook, the method errors because the input_parameter_definitions and output_parameter_definitions are missing type attribute in response.

Expected Behavior

input_parameter_definitions and output_parameter_definitions to have type attribute

Current Behavior

The field is missing

Possible Solution

Add the field as part of response in get_playbook

Steps to Reproduce

  1. Call get_playbook for a playbook having input and output parameters
  2. Use the playbook response from above to create a copy of the playbook using create_playbook

Context (Environment)

We are trying to copy the playbook with goals, instructions, examples and parameters into a new playbook for experimentations

@yashbadani-google yashbadani-google added the bug Something isn't working label Jul 16, 2024
@kmaphoenix kmaphoenix self-assigned this Jul 18, 2024
@kmaphoenix kmaphoenix added Generative Features Any features that utilizes LLMs Playbooks labels Jul 18, 2024
@kmaphoenix
Copy link
Member

Filed 354033686 for internal tracking.

@kmaphoenix
Copy link
Member

For clarity, this is a bug in the base Dialogflow CX SDK and the type field in the ParameterDefinition proto is not being returned with the Playbook proto.

Public docs list type_ as the field that should be returned.
https://cloud.google.com/python/docs/reference/dialogflow-cx/latest/google.cloud.dialogflowcx_v3beta1.types.ParameterDefinition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Generative Features Any features that utilizes LLMs Pending Bug Fix Playbooks
Projects
None yet
Development

No branches or pull requests

2 participants