We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the webhook in the target agent.
Does not perform any action.
based on https://github.com/googleapis/python-dialogflow-cx/blob/f2d12c53804dec7b236509aa29b200aebcc53c8a/google/cloud/dialogflowcx_v3beta1/types/webhook.py#L305-L308
we have to update the mask only if the kwargs pass to the function and not when we pass the webhook_obj.
mask
kwargs
webhook_obj
list_webhooks
dfcx_scrapi.core.webhoks.Webhooks
timeout
from datetime import timedelta my_webhook.timeout = timedelta(seconds=12)
webhook_instance.update_webhook( webhook_id=my_webhook.name, webhook_obj=my_webhook )
mask = None if kwargs: ... # existing code mask = field_mask_pb2.FieldMask(paths=paths) ... # existing code if mask: request.update_mask = mask ... # existing code
The text was updated successfully, but these errors were encountered:
BUG #111
e627dcb
@MRyderOC I just tested this on main and it seems to be working as intended.
main
If I don't pass any kwargs to the method, nothing is updated. That is by design.
If I pass a kwarg to the method, it updates just fine.
from google.protobuf import duration_pb2 all_webhooks = w.list_webhooks(pmarlow_demo) duration = duration_pb2.Duration() duration.seconds = 10 w.update_webhook(all_webhooks[0].name, all_webhooks[0], timeout=duration)
name: "<WEBHOOK_ID>" display_name: "long_running_webhook" generic_web_service { uri: "<WEBHOOK_URI>" } timeout { seconds: 30 }
name: "<WEBHOOK_ID>" display_name: "long_running_webhook" generic_web_service { uri: "<WEBHOOK_URI>" } timeout { seconds: 10 }
Sorry, something went wrong.
This specific bug will be addressed via another patch / branch.
MRyderOC
Successfully merging a pull request may close this issue.
Expected Behavior
Update the webhook in the target agent.
Current Behavior
Does not perform any action.
Possible Solution
based on https://github.com/googleapis/python-dialogflow-cx/blob/f2d12c53804dec7b236509aa29b200aebcc53c8a/google/cloud/dialogflowcx_v3beta1/types/webhook.py#L305-L308
we have to update the
mask
only if thekwargs
pass to the function and not when we pass thewebhook_obj
.Steps to Reproduce
list_webhooks
method indfcx_scrapi.core.webhoks.Webhooks
timeout
Possible Implementation
The text was updated successfully, but these errors were encountered: