Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k8s examples to use envvar instead of cli flags #1969

Open
hessjcg opened this issue Sep 20, 2023 · 0 comments
Open

Update k8s examples to use envvar instead of cli flags #1969

hessjcg opened this issue Sep 20, 2023 · 0 comments
Assignees
@hessjcg
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. type: docs Improvement to the documentation for an API.

Comments

@hessjcg
Copy link
Collaborator

hessjcg commented Sep 20, 2023 •
edited
Loading

Description

The operator uses environment variables to configure the proxy instead of CLI flags because it is easier
to accurately read and update the configuration. We introduce the envvar configuration to the k8s examples in #1950.

We should update all the k8s examples to use the envvar configuration instead of CLI flags.
@hessjcg hessjcg added the type: docs Improvement to the documentation for an API. label Sep 20, 2023
This was referenced Sep 20, 2023
Merged
Merged
@enocom enocom added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern. labels Sep 20, 2023
@enocom enocom assigned hessjcg and unassigned jackwotherspoon Sep 21, 2023
@enocom enocom added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hessjcg hessjcg

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@enocom @jackwotherspoon @hessjcg