Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for seamless cut over to newly promoted read replica #1831

Open
enocom opened this issue Jun 2, 2023 · 7 comments
Open

Add support for seamless cut over to newly promoted read replica #1831

enocom opened this issue Jun 2, 2023 · 7 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@enocom
Copy link
Member

enocom commented Jun 2, 2023

Feature Description

After promoting a read replica, the Proxy must be restarted with the new primary's instance connection name. Instead, it would be better if the Proxy could automatically connect to the newly promoted primary.

Currently, the Admin API will report if an instance is a primary or not (see here). Perhaps we could add support for specifying all read replicas and letting the Proxy "discover" the new primary (although this might cause a jump in Admin API quota usage).

For example,

./cloud-sql-proxy <INSTANCE_CONNECTION_NAME> \
  --replicas=<REPLICA_INSTANCE_CONNECTION_NAME_1>,<NAME_2>,<NAME_3>

Note: there is a work around, but it requires manually wrapping the Proxy and adding a backing storage.

@enocom enocom added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jun 2, 2023
@enocom enocom assigned enocom and unassigned jackwotherspoon Jun 2, 2023
@enocom enocom added the priority: p0 Highest priority. Critical issue. P0 implies highest priority. label Jun 2, 2023
@enocom
Copy link
Member Author

enocom commented Jun 2, 2023

Related to #1045.

@tomassommareqt
Copy link

We would really appreciate this feature.

@sinclabs
Copy link

sinclabs commented Nov 6, 2023

+1 on this! Would be great to have this one working

@jompa
Copy link

jompa commented Nov 6, 2023

This would be really nice! 👍

@davidforslof
Copy link

+1 on this!

@kristian-petersen
Copy link

+1 👍

@enocom
Copy link
Member Author

enocom commented Nov 6, 2023

It's in the works. There are some backend changes that will have to happen first, so the timeline isn't clear (especially with EOY freezes coming up), but we're actively working on this.

@enocom enocom added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p0 Highest priority. Critical issue. P0 implies highest priority. labels Feb 22, 2024
@enocom enocom assigned jackwotherspoon and unassigned enocom May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

7 participants