Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default VPC Requirement #1043

Open
hasibeg opened this issue Aug 22, 2023 · 6 comments
Open

default VPC Requirement #1043

hasibeg opened this issue Aug 22, 2023 · 6 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone

Comments

@hasibeg
Copy link

hasibeg commented Aug 22, 2023

Thanks for stopping by to let us know something could be better!

Is your feature request related to a problem? Please describe.
Sometimes the new projects don't have the default VPC network by default and the create script fails because GCE instances cannot be created.

Describe the solution you'd like
It might be good to mention that "default" auto VPC is a pre-req for the script to create the sandbox environment

Describe alternatives you've considered
Another alternative could be creating it as part of the terraform script if it doesn't exist.

Additional context

@NimJay NimJay added type: docs Improvement to the documentation for an API. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 22, 2023
@minherz minherz added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: docs Improvement to the documentation for an API. labels Aug 25, 2023
@minherz
Copy link
Collaborator

minherz commented Aug 25, 2023

@hasibeg hello, thank you for your suggestion. we will add support for the custom network and subnetwork arguments in CLI (sandboxctl) in the next minor version (0.10).

@minherz minherz added this to the version 0.10 milestone Aug 25, 2023
@lvaylet
Copy link

lvaylet commented Oct 2, 2023

@hasibeg I am in the same case, with an Org Policy removing the default VPC network from new projects. I have to create it manually, either from the console or with a gcloud command, then request a new provisioning.

@minherz These two options would definitely be good additions. I am not sure they solve the initial problem though. Delegating the creation of the default network to Terraform seems like a better, more seamless option.

@lvaylet
Copy link

lvaylet commented Oct 11, 2023

@minherz @hasibeg I pushed #1052 to create the default network if it does not exist already, to ensure backward compatibility with a non-breaking change.

@hasibeg
Copy link
Author

hasibeg commented Oct 13, 2023

Thank you @lvaylet and the team for the update !

@lvaylet
Copy link

lvaylet commented Oct 20, 2023

Fixed by #1052

@minherz
Copy link
Collaborator

minherz commented Nov 20, 2023

It seems that when auto_create_subnetworks is omitted, the network is created without subnetworks. As a result, GKE cluster cannot be created because subnetworks are missing.

@minherz minherz modified the milestones: version 0.10, backlog Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants