From 2490f9285d6d2e7a798dcbdf24ad71438b2e2a20 Mon Sep 17 00:00:00 2001 From: Abhishek Bhagwat Date: Thu, 19 Dec 2024 01:17:23 +0000 Subject: [PATCH] fix more linter errors --- .github/PULL_REQUEST_TEMPLATE.md | 22 +++++++++++----------- .github/workflows/linter.yaml | 4 ++-- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 74502483..43fae871 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,20 +2,20 @@ Thank you for your contribution! Please provide a brief description of your changes and ensure you've completed the checklist below. -### Description +## Description What does this PR do? Why is it necessary? **Fixes #** (if applicable) -### Checklist +## Checklist -* [ ] **Contribution Guidelines:** I have read the [Contribution Guidelines](../CONTRIBUTING). -* [ ] **CLA:** I have signed the [CLA](https://cla.developers.google.com). -* [ ] **Authorship:** I am listed as the author (if applicable). -* [ ] **Conventional Commits:** My PR title and commit messages follow the [Conventional Commits](https://www.conventialcommits.org) spec. -* [ ] **Code Format:** I have run `nox -s format` to format the code. -* [ ] **Spelling:** I have fixed any spelling errors, and added false positives to .github/actions/spelling/allow.txt if necessary. -* [ ] **Template:** I have followed the `aaie_notebook_template.ipynb` if submitting a new jupyter notbook. -* [ ] **Sync:** My Fork is synced with the upstream. -* [ ] **Documentations:** I have updated relevant documentations (if applicable) in the [docs folder](../docs). +- [ ] **Contribution Guidelines:** I have read the [Contribution Guidelines](../CONTRIBUTING). +- [ ] **CLA:** I have signed the [CLA](https://cla.developers.google.com). +- [ ] **Authorship:** I am listed as the author (if applicable). +- [ ] **Conventional Commits:** My PR title and commit messages follow the [Conventional Commits](https://www.conventialcommits.org) spec. +- [ ] **Code Format:** I have run `nox -s format` to format the code. +- [ ] **Spelling:** I have fixed any spelling errors, and added false positives to .github/actions/spelling/allow.txt if necessary. +- [ ] **Template:** I have followed the `aaie_notebook_template.ipynb` if submitting a new jupyter notbook. +- [ ] **Sync:** My Fork is synced with the upstream. +- [ ] **Documentations:** I have updated relevant documentations (if applicable) in the [docs folder](../docs). diff --git a/.github/workflows/linter.yaml b/.github/workflows/linter.yaml index a78c963d..888e1b5e 100644 --- a/.github/workflows/linter.yaml +++ b/.github/workflows/linter.yaml @@ -64,5 +64,5 @@ jobs: VALIDATE_GITHUB_ACTIONS: false VALIDATE_YAML_PRETTIER: false VALIDATE_JSCPD: false - - name: Make script executable - run: chmod +x .github/workflows/notebook_linter/run_linter.sh + FIX_SHELL_SHFMT: true + VALIDATE_BASH_EXEC: false