This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
Throw exception when app.yaml doesn't exist #451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
@googlebot I signed it! |
chanseokoh
reviewed
Sep 13, 2021
| testStager = new AppYamlStager(stageMojo, configBuilder); | ||
|
|
||
| try { | ||
| testStager.stage(); |
There was a problem hiding this comment.
Should have Assert.fail().
|
Actually, reading GoogleCloudPlatform/appengine-plugins#990, I think it's better to check the existence of either |
|
Oh, maybe the deployer is not involved when only staging? But I think it's still better to check early for the existence of an either file that can show a clear error message than falling through the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GoogleCloudPlatform/appengine-plugins#990
What changes were proposed in this pull request ?
The Stager Interface only check
appengine-web.xml, and it would work when bothapp.yamlandappengine-web.xmlare missing.This patch verified the existence of
app.yamlinAppYamlStager#stage().PS. Let me steal the idea of snippet in
AppDeployer: )How was this patch tested ?
Just touch new unit test. (Feel free to correct me if I miss something.)