fix(NddService): fix NddService socket.on('data') for large input #323
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
razorman8669
force-pushed
the
fix-#319
branch
from
39c1e23
to
309810c
Compare
|
@googlebot I fixed it. |
razorman8669
force-pushed
the
fix-#319
branch
2 times, most recently
from
af0a08b
to
f839cf6
Compare
This patch fixes NddService.server socker.on('data') so that it can handle large amounts of input without throwing `SyntaxError: Unexpected end of JSON input` errors.
Fixes GoogleChromeLabs#319
razorman8669
force-pushed
the
fix-#319
branch
from
f839cf6
to
8b16602
Compare
|
sorry for all the force pushes, between the CLA author rewrites to travis tooling...I was just moving too quick I guess 🤷 Anyways, I was experiencing this bug and patched it locally so I could get it working for myself. it works great with this patch. could I get a review on this? |
|
@ak239 et al, could one of you guys take a look at this and approve it. it's blocking some stuff i'm working on and I think it's a worthy contribution to the tool. |
This patch fixes NddService.server socker.on('data') so that it can handle large amounts of input without throwing
SyntaxError: Unexpected end of JSON inputerrors.Fixes #319