Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation should create unixy shortcuts on Windows when invoked through git bash #51

Open
jakub-g opened this issue Oct 30, 2018 · 2 comments

Comments

@jakub-g
Copy link

jakub-g commented Oct 30, 2018

When installing from git bash on Windows, the tool should create unixy shortcuts instead of cmd ones (or actually it could create both, so that things work from cmd as well as bash).

...
Installing wrapper script to ~\.jsvu\spidermonkey.cmd…
...
Installing wrapper script to ~\.jsvu\v8.cmd…

git bash can be recognized via /^MINGW(32|64)$/.test(process.env.MSYSTEM)

@mathiasbynens
Copy link
Member

Disclaimer: I don't actively use Windows and know very little about cmd or git bash.

Do the *.cmd ones not work in git bash?

@jakub-g
Copy link
Author

jakub-g commented Oct 30, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants