Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar not interactable with dialog #622

Open
Kitenite opened this issue May 2, 2024 · 6 comments
Open

Sidebar not interactable with dialog #622

Kitenite opened this issue May 2, 2024 · 6 comments

Comments

@Kitenite
Copy link
Contributor

Kitenite commented May 2, 2024

Thank you for the awesome work on the popover, this is a huge unlock!

I notice from testing that the side bar is still not interact-able when a dialog is open. Seems like Chrome is also capturing the click on the dialog even if it's not the top item in the top-layer. What do you think could be going on?

Arc.mp4
@Kitenite Kitenite changed the title Side bar not interact-able with dialog Sidebar not interact-able with dialog May 2, 2024
@Kitenite Kitenite changed the title Sidebar not interact-able with dialog Sidebar not interactable with dialog May 2, 2024
@argyleink
Copy link
Member

Looks to me like VisBug was opened before the Dialog, and so it's behind the dialog which ALSO has made the rest of the page inert. Curious, if you launch VisBug after the dialog is open, is the issue the same (probably still inert).

@Kitenite
Copy link
Contributor Author

Kitenite commented May 2, 2024

Yes, Visbug was opened after opening the dialog. Here's the top layer.

Screenshot 2024-05-02 at 5 09 49 PM

@argyleink
Copy link
Member

hmm, i just tested on 2 different <dialog> demo's I've made, and I can't recreate what you're experiencing?
Screenshot 2024-05-02 at 2 15 55 PM
Screenshot 2024-05-02 at 2 18 32 PM

@Kitenite
Copy link
Contributor Author

Kitenite commented May 2, 2024

Maybe a daisyui thing but it's not working for their modal
https://daisyui.com/components/modal/

@argyleink
Copy link
Member

oh i see! you can interact with the modal from visbug but not change tools. i can change the visbug tool via the hotkey, but can't click it.

attempts to click focus the modal too, def making me think this is about inert

Screenshot 2024-05-02 at 3 18 36 PM

hmmm, i'll ponder some workarounds, see if there's a way to keep visbug interactive. thanks for loggin this!

@Kitenite
Copy link
Contributor Author

Kitenite commented May 3, 2024

Np, thanks for pushing the update! I didn't know about inert, will take a look too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants