Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maintenance) Cross platform dev environment #573

Open
mayank99 opened this issue Oct 4, 2022 · 1 comment
Open

(maintenance) Cross platform dev environment #573

mayank99 opened this issue Oct 4, 2022 · 1 comment

Comments

@mayank99
Copy link
Contributor

mayank99 commented Oct 4, 2022

I couldn't get dev:extension to work on windows (it uses cp). When I tried using WSL (which does support cp), I got an error with sed.

sed: can't read s/{{NPM_VERSION}}/0.0.0/: No such file or directory

there's certainly some infra updates that could be done in the codebase to smooth out cross platform and cross IDE dev. need to block out some maintenance time. also need to update to manifest v3

Originally posted by @argyleink in #569 (comment)


Also (maybe unrelated):

  • Running npm install on latest version of node/npm recreates lockfile version 2
  • Saving file with prettier installed in VSCode messes up formatting. Perhaps a prettierrc or .vscode/settings.json (or both) is needed.
@argyleink
Copy link
Member

nice yeah, there's sed and cp and a few other unix commands in the scripts that could leverage a node package for cross platform support 👍🏻

regarding prettier, perhaps editor config's didnt age well and a migration from it to prettier could be helper. tho i think i'd go standardjs, as it's much more aligned with the style already in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants