Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly fix or delete OwnCloudExportTest #170

Open
djbrown opened this issue Jul 6, 2024 · 0 comments
Open

Properly fix or delete OwnCloudExportTest #170

djbrown opened this issue Jul 6, 2024 · 0 comments

Comments

@djbrown
Copy link

djbrown commented Jul 6, 2024

The ownCloud demo server was shut down.

OwnCloudExportTest has only one test case. It references the former demo server:

private String OC_SERVER = "https://demo.owncloud.org";

In #155 the test was modified to abort before connecting to the demo server.

The goal of this issue is to handle the test properly.

Possible solutions:

  1. delete the test (file)
  2. refactor for testability (dependency inversion) and pass implementation with static test behavior
  3. mock (override) existing production methods (using e.g. mockito)
  4. provide a mock server with static test behavior (using e.g. wiremock)
  5. setup a real ephemeral ownCloud instance within GitHub workflow and locally (using e.g. docker)
  6. setup a real persistant ownCloud instance with separate infrastructure (using e.g. google cloud platform)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant