New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats in Geom.subplot_grid #1516
Comments
Do you propose then to remove |
Not all stats to one layer, but to the appropriate layer, as happens in a |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the main Gadfly plot, Stats and Geoms that are not in layers, are both pushed into a layer (which makes sense). This means the
statistics
field of the main plot (p1.statistics
below) is actually obsolete.Geom.subplot_grid
has similar fields to the main plot. Insubplot_grid
Geoms that are not in layers get pushed to a layer,but Stats get pushed to the
statistics
field ofsubplot_grid
(p2.statistics
below). This is problematic,because the Stat and Geom don't have a clear association (this is worse when attempting to use multiple Stats/Geoms).
The decoupling of the Stat/Geom makes it makes it unclear what the purpose of
p2.statistics
is, leading to bad coding.The text was updated successfully, but these errors were encountered: