Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual regression tests #368

Open
CiaranOMara opened this issue Nov 6, 2019 · 2 comments
Open

Visual regression tests #368

CiaranOMara opened this issue Nov 6, 2019 · 2 comments

Comments

@CiaranOMara
Copy link
Contributor

I want to create a pull request for visual regression tests. So far, I've seen two variants, the one in Gadfly.jl, and various uses of VisualRegressionTests.jl. Do you have preferences for how to manage visual regression tests?

@Mattriks
Copy link
Member

Mattriks commented Nov 6, 2019

Also comments in #334. And currently the Compose docs are another visual test, and devs should be viewing them with any new PR.

@bjarthur
Copy link
Member

historically compose and gadlfy have been so tightly intertwined (they used to be one and the same before compose was split out) that gadfly's regression tests served double duty as testing compose as well. i think it's fine as is, but if someone wants to tackle this that'd be great. easiest would be to duplicate gadfly's comparison script. better would be to split it out into its own repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants