Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Filters API and Create a Hooks API #106

Open
hellofromtonya opened this issue Jan 20, 2018 · 1 comment
Open

Extend Filters API and Create a Hooks API #106

hellofromtonya opened this issue Jan 20, 2018 · 1 comment
Assignees
Milestone

Comments

@hellofromtonya
Copy link
Contributor

Actions API has an awesome collection of functionality that lets us do a smart add, modify, remove, replace, and reset. These functions truly are the missing components for the WordPress Plugin API.

Let's enhance the Filters API to add all of these functions.

I propose:

  1. Adding a Hooks API and rolling both the Actions and Filters into this one API.
  2. Moving the private functions into either class to hide away the complexity.
  3. Removing the global variable $_beans_registered_actions.
  4. Creating a container within the new class that replaces the global $_beans_registered_actions.
  5. Refactoring like functionality between the actions and filter.
  6. Removing _Beans_Anonymous_Actions and _Beans_Anonymous_Filters (needed for PHP 5.2)
  7. Replacing those classes with closures.
  8. Moving the existing code into the new (not yet built) Beans v1.5 plugin, which provides the backwards-compatibility for child themes running on Beans < 2.0.
@hellofromtonya
Copy link
Contributor Author

hellofromtonya commented Jan 20, 2018

I'd also suggest that we build it as a module and then submit it to Composer. This will allow non-Beans powered sites to utilize the Beans Hooks API.

Seriously, this is a really cool API and the missing functionality within Core. I think the WordPress Community is going to want this baby even if they are not using a Beans powered theme.

@hellofromtonya hellofromtonya added this to the v1.6 milestone Jul 6, 2018
@christophherr christophherr modified the milestones: v1.6, v2.0 Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants