Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMA] X Hero Siege: Reborn #89

Open
EarthSalamander42 opened this issue Jan 11, 2017 · 16 comments
Open

[SCHEMA] X Hero Siege: Reborn #89

EarthSalamander42 opened this issue Jan 11, 2017 · 16 comments

Comments

@EarthSalamander42
Copy link

EarthSalamander42 commented Jan 11, 2017

Console Log: https://pastebin.com/0AFrwT5C
Settings.kv: https://pastebin.com/b5DLGsPV
Schema.lua: https://pastebin.com/vuvUAkra
Addon_game_mode.lua: https://pastebin.com/yUhggNeD
-- EDIT
gamemode.lua: https://pastebin.com/neNCNmbb

@jimmydorry
Copy link
Member

Great work. My only suggestion is to round that game time to a nice integer value.

game.gl = math.floor(GameRules:GetDOTATime(false, false))

@jimmydorry
Copy link
Member

jimmydorry commented Jan 11, 2017

Here's your schema, please review the fields to make sure I didn't make a mistake.

Feel free to suggest changes!

Schema: https://getdotastats.com/#s2__mod_schema?mid=105

Schema ID: https://getdotastats.com/#s2__my__mods

@EarthSalamander42
Copy link
Author

Updated links, Game values get recorded but Player values doesn't :/

@jimmydorry
Copy link
Member

Are you on a recent version of the library?

Give us internal/util and gamemode

You should really also be looking at fixing some of those errors too.

@EarthSalamander42
Copy link
Author

A lot of my mod errors happened because i've used host_timescale 10, here is util:

@jimmydorry
Copy link
Member

You gave internal/util I assume, what about gamemode, where I assume the game logic is?

I don't yet have anything I can look at to see how your mod could even start without invoking statcollection:init()

You also didn't clarify whether this is with a recent version of the library or not.

@EarthSalamander42
Copy link
Author

Don't mind the mess in my gamemode.. ^^
gamemode: https://hastebin.com/yutaxepabe.lua

@EarthSalamander42
Copy link
Author

I'm recreating a request, because the old ones didn't made it my lib was out of date. (also it seems to work after few tests)
addon_game_mode.lua: https://pastebin.com/ms5Qw7NC
schema.lua: https://pastebin.com/AVe23UU0
settings.kv: https://pastebin.com/e5g0TUBS
Console Log: https://pastebin.com/8MVJ3hwQ

@EarthSalamander42
Copy link
Author

New schema request!

schema.lua: https://hastebin.com/liyogeyugo.lua

@jimmydorry
Copy link
Member

Here's your schema, please review the fields to make sure I didn't make a mistake.

Feel free to suggest changes!

Schema: https://getdotastats.com/#s2__mod_schema?mid=105

Schema ID: https://getdotastats.com/#s2__my__mods

Your schema starts with S1 no v3.

@EarthSalamander42
Copy link
Author

Whoops! few errors fixed, sorry about that: https://hastebin.com/yegusecide.lua

@jimmydorry
Copy link
Member

Doesn't look any different in terms of what fields I am expecting.

@EarthSalamander42
Copy link
Author

I was not sure if changes was needed from your side tbh so i've sent back!

@jimmydorry
Copy link
Member

Nothing needed on our end. Good luck.

If you are having problems, check that console log first.

@EarthSalamander42
Copy link
Author

image
Btw you told me it would be referenced as s1, not v3, but i'm only seeing the new v3 one, could this be the cause?

@jimmydorry
Copy link
Member

It's in your mod list. I'll PM you the schema key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants