Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ntv2reader module tests #80

Open
harry093 opened this issue Oct 1, 2019 · 1 comment
Open

Move ntv2reader module tests #80

harry093 opened this issue Oct 1, 2019 · 1 comment
Labels
test Improves test coverage

Comments

@harry093
Copy link
Collaborator

harry093 commented Oct 1, 2019

At the bottom of the ntv2reader module there is a test. This should be moved to a file in the geodepy/tests/ directory.

The existing test has a hardcoded path in it. Should this be removed?

@BatchelorJ
Copy link
Collaborator

I hadn't noticed this, that's really great! We could move this to a new test module, download the file from the ICSM S3 Bucket to a temporary directory using the tempfile module (see test_surveyconvert module), then run the tests using the temporary copy. Not sure of the impact on performance of downloading a 236 MB file each time the tests are run, but it's an option. Another would be to get Jack to create a small test grid (say 20 x 20 nodes) that we could put directly in the test suite.

@BatchelorJ BatchelorJ added the test Improves test coverage label Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Improves test coverage
Projects
None yet
Development

No branches or pull requests

2 participants